-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix/external upload limit #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kota-Jagadeesh
wants to merge
12
commits into
commons-app:main
Choose a base branch
from
Kota-Jagadeesh:fix/external-upload-limit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/external upload limit #6556
Kota-Jagadeesh
wants to merge
12
commits into
commons-app:main
from
Kota-Jagadeesh:fix/external-upload-limit
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RitikaPahwa4444
requested changes
Nov 9, 2025
Collaborator
Author
|
@nicolas-raoul @RitikaPahwa4444 Any update on this PR ? |
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version is enhanced from the initial proposal (#6555) and includes key refactorings:
A non-blocking toast is shown to the user informing them that only the first 20 files were loaded, ensuring workflow continuity with clear feedback.
Both UploadActivity.kt and CustomSelectorActivity.kt now correctly reference this centralized constant, improving code maintainability and adherence to DRY principles.